Messages in this thread | | | Subject | Re: [PATCH v2] net: ethernet: stmmac: dwmac-rk: Add GMAC support for PX30 | From | David Wu <> | Date | Fri, 22 Jun 2018 15:22:35 +0800 |
| |
Hi Heiko,
在 2018年06月14日 16:30, Heiko Stübner 写道: > And someone could convert the driver to use the new clk-bulk APIs [0], > so the large number of clk_prepare_enable calls would be a bit > trimmed down.
Some clocks need special treatment at special cases, may not know which index is we need at clk_bulk_data struct. 1. At rmii mode, need to use mac_ref, mac_refout; but at rgmii, they are not needed. 2. At rgmii mode, rx is coming in from external source, there is no gate, and it is coming from mac_ref_clk at rmii mode, there is gate. 3. clk_mac needs to be configured rate 50M or 125M. 4. mac_clk_speed needs to be configured at PX30 Soc and next Socs.
It looks like use the clk-bulk, will not be more flexible, and we still keep the present. What do you think?
| |