Messages in this thread | | | Date | Fri, 22 Jun 2018 19:43:59 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH REBASED RESEND] x86/cpu: Move early cpu initialization into a separate translation unit |
| |
On Fri, Jun 22, 2018 at 06:50:56PM +0200, Thomas Gleixner wrote: > > The magic, which I cut out, will rewrite the "jmp 6f, nops" thing to > > "jmp %l[y_{yes,no}]" at the alternative patching and we'll loose the > > dynamic test, pinning the condition forever more. > > Hrm. Memory seems have to tricked me. So yes, it should work then.
Yes, but do verify that it does still. Because depending on how early you call it, boot_cpu_data.x86_capability might not be populated properly yet and then the dynamic case is wrong too. So check the order pls.
> Though I still prefer the two liners fixup of the cpu_init() section > mismatch thingy for now over the whole code move. Especially since Borislav > and I have plans to rework that insanity completely once the speculative > distractions are subsiding.
Hell yeah.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |