Messages in this thread Patch in this message | | | Date | Wed, 20 Jun 2018 20:28:44 +0200 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH v2 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC |
| |
On Tue, May 15, 2018 at 02:12:39PM +0200, Andrzej Hajda wrote: > OF graph describes USB data lanes between USB-PHY and respective MUIC. > Since graph is present and DWC driver can use it to get extcon, obsolete > extcon property can be removed. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > .../dts/exynos/exynos5433-tm2-common.dtsi | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-)
dtc W=1 now complains with: === Warning (graph_child_address): /soc/hsi2c@14d90000/max77843@66/max77843-muic/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary ===
Do you plan to add more ports soon?
Best regards, Krzysztof
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > index 03453b822093..042e5894a138 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > @@ -868,6 +868,18 @@ > }; > }; > }; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + muic_to_usb: endpoint { > + remote-endpoint = <&usb_to_muic>; > + }; > + }; > + }; > }; > > regulators { > @@ -1287,12 +1299,17 @@ > > &usbdrd_dwc3 { > dr_mode = "otg"; > - extcon = <&muic>; > }; > > &usbdrd30_phy { > vbus-supply = <&safeout1_reg>; > status = "okay"; > + > + port { > + usb_to_muic: endpoint { > + remote-endpoint = <&muic_to_usb>; > + }; > + }; > }; > > &xxti { > -- > 2.17.0 >
| |