Messages in this thread | | | Date | Wed, 20 Jun 2018 12:01:54 -0600 | From | Rob Herring <> | Subject | Re: [PATCH V3 1/3] scsi: ufs: set the device reference clock setting |
| |
On Wed, Jun 20, 2018 at 10:26:07AM +0300, Adrian Hunter wrote: > On 14/06/18 16:03, Sayali Lokhande wrote: > > From: Subhash Jadavani <subhashj@codeaurora.org> > > > > UFS host supplies the reference clock to UFS device and UFS device > > specification allows host to provide one of the 4 frequencies (19.2 MHz, > > 26 MHz, 38.4 MHz, 52 MHz) for reference clock. Host should set the > > device reference clock frequency setting in the device based on what > > frequency it is supplying to UFS device. > > > > Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org> > > Signed-off-by: Can Guo <cang@codeaurora.org> > > Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org> > > I have repeated my V2 comments below. Please address these when you post > V4. Also please provide a change log for each patch version.
Do I have to repeat my V2 comments too? Please don't send a V4 until the discussion on V2 is resolved.
Rob
| |