Messages in this thread | | | Date | Wed, 20 Jun 2018 15:58:41 +0530 | From | Vinod <> | Subject | Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support |
| |
On 20-06-18, 10:53, Srinivas Kandagatla wrote: > On 20/06/18 10:31, Vinod wrote: > > > Here clock will be enabled twice but disable will be called only once when > > > count = 0. > > > > > > This will make the clock always enabled. So, I think we should keep either > > > mutex lock or atomic variable to synchronize this. > > we are using DPCM here right? > > We should probably model this clk as DAPM widget so we do not need to handle > this in machine code.
Sure that would be even better, but my point was that we need not worry about .startup racing in case of DPCM as it holds a card mutex before it calls PCM ops.. so it is already serialized..
-- ~Vinod
| |