Messages in this thread | | | From | Pavel Tatashin <> | Date | Wed, 20 Jun 2018 22:35:18 -0400 | Subject | Re: [PATCH 3/4] mm/memory_hotplug: Get rid of link_mem_sections |
| |
On Fri, Jun 1, 2018 at 8:54 AM <osalvador@techadventures.net> wrote: > > From: Oscar Salvador <osalvador@suse.de> > > link_mem_sections() and walk_memory_range() share most of the code, > so we can use walk_memory_range() with a callback to register_mem_sect_under_node() > instead of using link_mem_sections().
Yes, their logic is indeed identical, so it is good to replace some code with walk_memory_range().
> > To control whether the node id must be check, two new functions has been added: > > register_mem_sect_under_node_nocheck_node() > and > register_mem_sect_under_node_check_node()
I do not like this, please see if my suggestion is better:
1. Revert all the changes outside of link_mem_sections() 2. Remove check_nid argument from register_mem_sect_under_node and link_mem_sections. 3. In register_mem_sect_under_node Replace:
if (check_nid) { }
With: if (system_state == SYSTEM_BOOTING) { }
4. Change register_mem_sect_under_node() prototype to match callback of walk_memory_range() 5. Call walk_memory_range(... register_mem_sect_under_node ...) from link_mem_sections
Thank you, Pavel
| |