Messages in this thread | | | From | Kees Cook <> | Date | Wed, 20 Jun 2018 15:35:10 -0700 | Subject | Re: [PATCH 1/3] vmalloc: Add __vmalloc_node_try_addr function |
| |
On Wed, Jun 20, 2018 at 3:16 PM, Randy Dunlap <rdunlap@infradead.org> wrote: > On 06/20/2018 03:09 PM, Rick Edgecombe wrote: >> +void *__vmalloc_node_try_addr(unsigned long addr, unsigned long size, >> + gfp_t gfp_mask, pgprot_t prot, unsigned long vm_flags, >> + int node, const void *caller) >> +{ > > so this isn't optional, eh? You are going to force it on people because?
RANDOMIZE_BASE isn't optional either. :) This improves the module address entropy with (what seems to be) no down-side, so yeah, I think it should be non-optional. :)
-Kees
-- Kees Cook Pixel Security
| |