Messages in this thread | | | Subject | Re: [PATCH v11 04/13] x86, sgx: add SGX definitions to msr-index.h | From | Dave Hansen <> | Date | Tue, 19 Jun 2018 07:01:57 -0700 |
| |
On 06/19/2018 06:18 AM, Jarkko Sakkinen wrote: > On Fri, Jun 08, 2018 at 10:25:29AM -0700, Dave Hansen wrote: >> On 06/08/2018 10:09 AM, Jarkko Sakkinen wrote: >>> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> >>> Signed-off-by: Haim Cohen <haim.cohen@intel.com> >>> Tested-by: Serge Ayoun <serge.ayoun@intel.com> >>> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> >>> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> >>> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> >> >> These are a mess. If you're signing off on it, a review of some kind is >> pretty implied. >> >> Also, how did Sean write this, send it to Haim to sign off on it, and >> then send it to you? That seems unlikely. > > They've both done something to this. How should I change it then?
Who added their Signed-off-by?
I would probably add a single "Co-developed-by:" for each of them and a single Signed-off-by, like commit 12c89130a56ae:
Co-developed-by: Tony Luck <tony.luck@intel.com> Reported-by: Mika Penttilä <mika.penttila@nextfour.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Andy Lutomirski <luto@amacapital.net> ...
| |