lkml.org 
[lkml]   [2018]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH v2 5/6] mtd: rawnand: micron: add ONFI_FEATURE_ON_DIE_ECC to supported features
Date
On 19/06/18 18:53, Miquel Raynal wrote:
> Hi Boris, Chris,
>
> On Tue, 19 Jun 2018 07:40:56 +0200, Boris Brezillon
> <boris.brezillon@bootlin.com> wrote:
>
>> On Tue, 19 Jun 2018 17:31:24 +1200
>> Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
>>
>>> Add ONFI_FEATURE_ON_DIE_ECC to the set/get features list for Micron
>>> NAND flash.
>>>
>>
>> Fixes: 789157e41a06 ("mtd: rawnand: allow vendors to declare (un)supported features")
>
> Sorry for breaking it in my previous series.
>
>> Cc: <stable@vger.kernel.org>
>>
>> No need to send a new version, I'll add that when queuing the patch.
>>
>> Miquel, if you're okay, I'm gonna take this patch in the mtd/fixes branch
>> and let you deal with other patches in this series.
>
> Yes please, take this one.
>
> * Chris, I'll take patches 1, 2, 3 with Boris comments.

OK.

I also got a kbuild report on

include/linux/mtd/rawnand.h:788: warning: Function parameter or member
'fixup_onfi_param_page' not described in 'nand_manufacturer_ops'

Do you want me to send a v3 for that? (given our timezones I'll just
send it anyway and you can choose to take it or just stick with v2).

> * Patch 4 I think I'll just drop it as nobody can test it (and it's a
> oneliner). I prefer people requesting a feature than complaining
> about a bug :)

Agreed. It's in the mailing list archive now if someone needs it we can
resurrect it from there

> * Boris will take patch 5 in the mtd/fixes branch.

Thanks all. Sorry our emails crossed so I couldn't just send #5 as a fix
on it's own.

> * I'll let you write a v3 for patch 6 only.

I'll have a read through the old thread and see if I can make sense of it.

\
 
 \ /
  Last update: 2018-06-19 23:23    [W:0.072 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site