Messages in this thread | | | Date | Mon, 18 Jun 2018 15:14:20 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH v2] printk: make sure to print log on console. |
| |
On (06/08/18 10:39), Petr Mladek wrote: [..] > It might make sense to document the limitations reported by > Sergey. I mean to add something like: > > "There are still some corner cases where this patch is not enough, > for example, when the messages are flushed later from printk_safe > buffers or when there are races between console_verbose() and > console_silent() callers."
Agree. Probably a link to the email would also be helpful.
> > reused flag LOG_NOCONS as its usage is gone long back. > > (5c2992ee7fd8a29d04125dc0aa3522784c5fa5eb) > > > > Signed-off-by: Vaneet Narang <v.narang@samsung.com> > > Signed-off-by: Maninder Singh <maninder1.s@samsung.com> > > Anyway. the patch helps in many situations and it is a step in the right > direction:
So I'm not objecting the patch and will review it shortly.
For educational purposes only: Would be appreciated if you guys could point out what those "many situations" are (in the mainline kernel). Could you do that for me? This is a real question.
Otherwise it feels like I'm missing the real [mainline kernel] importance and significance of this patch.
-ss
| |