lkml.org 
[lkml]   [2018]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 058/279] drm/msm/dsi: use correct enum in dsi_get_cmd_fmt
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Stefan Agner <stefan@agner.ch>

    [ Upstream commit a4af89286f8fc382459308764ea05935dc477cdc ]

    The function dsi_get_cmd_fmt returns enum dsi_cmd_dst_format,
    use the correct enum value also for MIPI_DSI_FMT_RGB666/_PACKED.

    This has been discovered using clang:
    drivers/gpu/drm/msm/dsi/dsi_host.c:743:35: warning: implicit conversion
    from enumeration type 'enum dsi_vid_dst_format' to different
    enumeration type 'enum dsi_cmd_dst_format' [-Wenum-conversion]
    case MIPI_DSI_FMT_RGB666: return VID_DST_FORMAT_RGB666;
    ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~

    Signed-off-by: Stefan Agner <stefan@agner.ch>
    Reviewed-by: Archit Taneja <architt@codeaurora.org>
    Signed-off-by: Rob Clark <robdclark@gmail.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
    +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
    @@ -740,7 +740,7 @@ static inline enum dsi_cmd_dst_format ds
    switch (mipi_fmt) {
    case MIPI_DSI_FMT_RGB888: return CMD_DST_FORMAT_RGB888;
    case MIPI_DSI_FMT_RGB666_PACKED:
    - case MIPI_DSI_FMT_RGB666: return VID_DST_FORMAT_RGB666;
    + case MIPI_DSI_FMT_RGB666: return CMD_DST_FORMAT_RGB666;
    case MIPI_DSI_FMT_RGB565: return CMD_DST_FORMAT_RGB565;
    default: return CMD_DST_FORMAT_RGB888;
    }

    \
     
     \ /
      Last update: 2018-06-18 12:02    [W:4.021 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site