lkml.org 
[lkml]   [2018]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 170/279] ARM: dts: correct missing "compatible" entry for ti81xx SoCs
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Graeme Smecher <gsmecher@threespeedlogic.com>

    [ Upstream commit 647efef69de483f1dd7944ede31b4cae16acb124 ]

    The missing "compatible" entries are needed by drivers/clk/ti/clkctrl.c,
    and without them the structures initialized in drivers/clk/ti/clk-814x.c
    are not passed to configuration code. The result is a "not found from
    clkctrl data" error message, although boot proceeds anyway.

    The reason why the compatible is not found is because the board specific
    files override the SoC compatible without including it. This did not
    cause any issues until with the clkctrl nodes got introduced.

    Very lightly tested on a (lurching) AM3874 design that's in the middle
    of a kernel upgrade from TI's abandoned 2.6.37 tree.

    Also tested on j5eco-evm and hp-t410 to verify the clkctrl clocks are
    found.

    Fixes: bb30465b5902 ("ARM: dts: dm814x: add clkctrl nodes")
    Fixes: 80a06c0d8357 ("ARM: dts: dm816x: add clkctrl nodes")
    Signed-off-by: Graeme Smecher <gsmecher@threespeedlogic.com>
    [tony: updated to fix for 8168-evm, updated comments]
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/arm/boot/dts/dm8148-evm.dts | 2 +-
    arch/arm/boot/dts/dm8148-t410.dts | 2 +-
    arch/arm/boot/dts/dm8168-evm.dts | 2 +-
    arch/arm/boot/dts/dra62x-j5eco-evm.dts | 2 +-
    4 files changed, 4 insertions(+), 4 deletions(-)

    --- a/arch/arm/boot/dts/dm8148-evm.dts
    +++ b/arch/arm/boot/dts/dm8148-evm.dts
    @@ -10,7 +10,7 @@

    / {
    model = "DM8148 EVM";
    - compatible = "ti,dm8148-evm", "ti,dm8148";
    + compatible = "ti,dm8148-evm", "ti,dm8148", "ti,dm814";

    memory@80000000 {
    device_type = "memory";
    --- a/arch/arm/boot/dts/dm8148-t410.dts
    +++ b/arch/arm/boot/dts/dm8148-t410.dts
    @@ -9,7 +9,7 @@

    / {
    model = "HP t410 Smart Zero Client";
    - compatible = "hp,t410", "ti,dm8148";
    + compatible = "hp,t410", "ti,dm8148", "ti,dm814";

    memory@80000000 {
    device_type = "memory";
    --- a/arch/arm/boot/dts/dm8168-evm.dts
    +++ b/arch/arm/boot/dts/dm8168-evm.dts
    @@ -10,7 +10,7 @@

    / {
    model = "DM8168 EVM";
    - compatible = "ti,dm8168-evm", "ti,dm8168";
    + compatible = "ti,dm8168-evm", "ti,dm8168", "ti,dm816";

    memory@80000000 {
    device_type = "memory";
    --- a/arch/arm/boot/dts/dra62x-j5eco-evm.dts
    +++ b/arch/arm/boot/dts/dra62x-j5eco-evm.dts
    @@ -10,7 +10,7 @@

    / {
    model = "DRA62x J5 Eco EVM";
    - compatible = "ti,dra62x-j5eco-evm", "ti,dra62x", "ti,dm8148";
    + compatible = "ti,dra62x-j5eco-evm", "ti,dra62x", "ti,dm8148", "ti,dm814";

    memory@80000000 {
    device_type = "memory";

    \
     
     \ /
      Last update: 2018-06-18 11:30    [W:4.095 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site