Messages in this thread | | | Date | Fri, 15 Jun 2018 11:58:10 +0100 | From | James Hogan <> | Subject | Re: [PATCH 4/4] rseq/selftests: Implement MIPS support |
| |
On Thu, Jun 14, 2018 at 04:52:10PM -0700, Paul Burton wrote: > +#define __RSEQ_ASM_DEFINE_TABLE(version, flags, start_ip, \
Nit: technically all these \'s are on 81st column...
> +#define __RSEQ_ASM_DEFINE_ABORT(table_label, label, teardown, \ > + abort_label, version, flags, \ > + start_ip, post_commit_offset, abort_ip) \ > + ".balign 32\n\t" \
ARM doesn't do this for DEFINE_ABORT. Is it intentional that we do for MIPS?
Otherwise this whole series looks reasonable to me, so feel free to add my rb on the whole series if you do apply youself:
Reviewed-by: James Hogan <jhogan@kernel.org>
Thanks James [unhandled content-type:application/pgp-signature] | |