Messages in this thread | | | From | Nick Desaulniers <> | Date | Thu, 14 Jun 2018 13:59:45 -0700 | Subject | Re: [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h> |
| |
On Thu, Jun 14, 2018 at 1:48 PM H. Peter Anvin <hpa@zytor.com> wrote: > > On 06/13/18 14:05, Nick Desaulniers wrote: > > From: "H. Peter Anvin" <hpa@linux.intel.com> > > > > i386 and x86-64 uses different registers for arguments; make them > > available so we don't have to #ifdef in the actual code. > > > > Native size and specified size (q, l, w, b) versions are provided. > > > > Suggested-by: Sedat Dilek <sedat.dilek@gmail.com> > > Signed-off-by: H. Peter Anvin <hpa@linux.intel.com> > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > > I still object to Suggested-by: here. Sedat did a correction, which is > a Reviewed-by:, but unless I'm completely out to sea, there was no > suggestion on Sedat's part of this; and I had certainly not seen it when > I wrote the code.
I'm fine with changing it from a Suggested-by to a Reviewed-by. Can you do that when you apply the set, or should I send a v6? -- Thanks, ~Nick Desaulniers
| |