lkml.org 
[lkml]   [2018]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.17 43/45] crypto: vmx - Remove overly verbose printk from AES init routines
    Date
    4.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Michael Ellerman <mpe@ellerman.id.au>

    commit 1411b5218adbcf1d45ddb260db5553c52e8d917c upstream.

    In the vmx AES init routines we do a printk(KERN_INFO ...) to report
    the fallback implementation we're using.

    However with a slow console this can significantly affect the speed of
    crypto operations. Using 'cryptsetup benchmark' the removal of the
    printk() leads to a ~5x speedup for aes-cbc decryption.

    So remove them.

    Fixes: 8676590a1593 ("crypto: vmx - Adding AES routines for VMX module")
    Fixes: 8c755ace357c ("crypto: vmx - Adding CBC routines for VMX module")
    Fixes: 4f7f60d312b3 ("crypto: vmx - Adding CTR routines for VMX module")
    Fixes: cc333cd68dfa ("crypto: vmx - Adding GHASH routines for VMX module")
    Cc: stable@vger.kernel.org # v4.1+
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/crypto/vmx/aes.c | 2 --
    drivers/crypto/vmx/aes_cbc.c | 3 ---
    drivers/crypto/vmx/aes_ctr.c | 2 --
    drivers/crypto/vmx/ghash.c | 2 --
    4 files changed, 9 deletions(-)

    --- a/drivers/crypto/vmx/aes.c
    +++ b/drivers/crypto/vmx/aes.c
    @@ -48,8 +48,6 @@ static int p8_aes_init(struct crypto_tfm
    alg, PTR_ERR(fallback));
    return PTR_ERR(fallback);
    }
    - printk(KERN_INFO "Using '%s' as fallback implementation.\n",
    - crypto_tfm_alg_driver_name((struct crypto_tfm *) fallback));

    crypto_cipher_set_flags(fallback,
    crypto_cipher_get_flags((struct
    --- a/drivers/crypto/vmx/aes_cbc.c
    +++ b/drivers/crypto/vmx/aes_cbc.c
    @@ -52,9 +52,6 @@ static int p8_aes_cbc_init(struct crypto
    alg, PTR_ERR(fallback));
    return PTR_ERR(fallback);
    }
    - printk(KERN_INFO "Using '%s' as fallback implementation.\n",
    - crypto_skcipher_driver_name(fallback));
    -

    crypto_skcipher_set_flags(
    fallback,
    --- a/drivers/crypto/vmx/aes_ctr.c
    +++ b/drivers/crypto/vmx/aes_ctr.c
    @@ -50,8 +50,6 @@ static int p8_aes_ctr_init(struct crypto
    alg, PTR_ERR(fallback));
    return PTR_ERR(fallback);
    }
    - printk(KERN_INFO "Using '%s' as fallback implementation.\n",
    - crypto_skcipher_driver_name(fallback));

    crypto_skcipher_set_flags(
    fallback,
    --- a/drivers/crypto/vmx/ghash.c
    +++ b/drivers/crypto/vmx/ghash.c
    @@ -64,8 +64,6 @@ static int p8_ghash_init_tfm(struct cryp
    alg, PTR_ERR(fallback));
    return PTR_ERR(fallback);
    }
    - printk(KERN_INFO "Using '%s' as fallback implementation.\n",
    - crypto_tfm_alg_driver_name(crypto_shash_tfm(fallback)));

    crypto_shash_set_flags(fallback,
    crypto_shash_get_flags((struct crypto_shash

    \
     
     \ /
      Last update: 2018-06-14 16:52    [W:3.255 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site