lkml.org 
[lkml]   [2018]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/4] net: emaclite: Remove xemaclite_mdio_setup return check
    On Wed, Jun 13, 2018 at 12:05:19PM +0530, Radhey Shyam Pandey wrote:
    > Errors are already reported in xemaclite_mdio_setup so avoid
    > reporting it again.
    >
    > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
    > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
    > ---
    > drivers/net/ethernet/xilinx/xilinx_emaclite.c | 4 +---
    > 1 files changed, 1 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
    > index ec4608e..2a0c06e 100644
    > --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
    > +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
    > @@ -1143,9 +1143,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
    > xemaclite_update_address(lp, ndev->dev_addr);
    >
    > lp->phy_node = of_parse_phandle(ofdev->dev.of_node, "phy-handle", 0);
    > - rc = xemaclite_mdio_setup(lp, &ofdev->dev);
    > - if (rc)
    > - dev_warn(&ofdev->dev, "error registering MDIO bus\n");
    > + xemaclite_mdio_setup(lp, &ofdev->dev);
    >
    > dev_info(dev, "MAC address is now %pM\n", ndev->dev_addr);

    The patch itself is O.K.

    Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    However, do you want to keep going if the MDIO bus fails? Maybe you
    should failed the probe?

    Andrew

    \
     
     \ /
      Last update: 2018-06-13 09:29    [W:9.349 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site