Messages in this thread | | | Date | Wed, 13 Jun 2018 21:10:37 -0400 | From | Hugo Lefeuvre <> | Subject | Re: [PATCH v2] staging: pi433: fix race condition in pi433_ioctl |
| |
Hi Dan,
> There is no need for this comment, since it's obvious. Also if you use > simpler names then the copy fits on one line: > > if (copy_from_user(&tx_cfg, argp, sizeof(tx_cfg)) { > > > > + mutex_lock(&device->tx_fifo_lock); > > + if (copy_from_user(&tx_cfg_buffer, argp, > > + sizeof(struct pi433_tx_cfg))) { > > Sorry for the duplicate review, but it got sent to both my inboxes... :P
Thanks for your review ! Patch updated.
Please tell me if you don't to be CC-ed anymore. :)
regards, Hugo
-- Hugo Lefeuvre (hle) | www.owl.eu.com 4096/ 9C4F C8BF A4B0 8FC5 48EB 56B8 1962 765B B9A8 BACA [unhandled content-type:application/pgp-signature] | |