Messages in this thread | | | From | NeilBrown <> | Date | Thu, 14 Jun 2018 09:21:37 +1000 | Subject | Re: [PATCH 11/11] staging: lustre: centralize setting of subdir-ccflags-y |
| |
On Wed, Jun 13 2018, James Simmons wrote:
>> We don't need to set subdir-ccflags-y in every Makefile. >> The whole point of the "subdir-" bit is that the setting >> can go once in the top-level Makefile. >> > > Nak: When attempting to build individual components I get: > > ~/lustre-upstream$ make SUBDIRS=drivers/staging/lustre/lustre/lmv modules > -j 16 > > WARNING: Symbol version dump ./Module.symvers > is missing; modules will have no dependencies and modversions. > > CC [M] drivers/staging/lustre/lustre/lmv/lmv_obd.o > CC [M] drivers/staging/lustre/lustre/lmv/lmv_intent.o > CC [M] drivers/staging/lustre/lustre/lmv/lmv_fld.o > CC [M] drivers/staging/lustre/lustre/lmv/lproc_lmv.o > drivers/staging/lustre/lustre/lmv/lproc_lmv.c:38:28: fatal error: > lprocfs_status.h: No such file or directory > #include <lprocfs_status.h> > ^ > compilation terminated.
Yes, I noticed that too. Thanks. It seems to suggest that subdir-ccflags-y isn't really a useful macro. Maybe we should stick with cc-flags-y. It is much more widely used.
Thanks, NeilBrown
[unhandled content-type:application/pgp-signature] | |