Messages in this thread | | | Date | Wed, 13 Jun 2018 11:29:44 -0400 | From | okaya@codeauro ... | Subject | Re: [PATCH V2 2/2] efi/fb: Convert PCI bus address to resource if translated by the bridge |
| |
On 2018-06-13 11:22, Ard Biesheuvel wrote: > On 13 June 2018 at 17:17, <okaya@codeaurora.org> wrote: >> On 2018-06-13 11:06, Ard Biesheuvel wrote: >>> >>> On 13 June 2018 at 16:22, Sinan Kaya <okaya@codeaurora.org> wrote: >>>> >>>> Hi Ard, >>>> >>>> On 5/18/2018 10:17 AM, Sinan Kaya wrote: >>>>> >>>>> A host bridge is allowed to remap BAR addresses using _TRA >>>>> attribute in >>>>> _CRS windows. >>>>> >>>>> pci_bus 0000:00: root bus resource [mem 0x80100100000-0x8011fffffff >>>>> window] (bus address [0x00100000-0x1fffffff]) >>>>> pci 0000:02:00.0: reg 0x10: [mem 0x8011e000000-0x8011effffff] >>>>> >>>>> When a VGA device is behind such a host bridge and the resource is >>>>> translated efifb driver is trying to do ioremap against bus address >>>>> rather than the resource address and is failing to probe. >>>>> >>>>> efifb: probing for efifb >>>>> efifb: cannot reserve video memory at 0x1e000000 >>>>> efifb: framebuffer at 0x1e000000, using 1920k, total 1875k >>>>> efifb: mode is 800x600x32, linelength=3200, pages=1 >>>>> efifb: scrolling: redraw >>>>> efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0 >>>>> >>>>> Use the host bridge offset information to convert bus address to >>>>> resource address in the fixup. >>>>> >>>>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org> >>>>> --- >>>> >>>> >>>> I didn't see any messages about these getting picked up for 4.18. >>>> >>>> Are they queued on your own branch? >>>> >>> >>> No, you never cc'ed me on them until now. >> >> >> Ouch, I hoped that you would get it via get_maintainer script. Sorry >> for >> that. > > Actually, get_maintainer is right: this should go through the fbdev > tree not the EFI tree > > Were you going to resend them? If not, I can find them in my archive > and ack them, and we will ask Bartlomiej to take them for v4.19
I prefer ack rather than resend to be honest.
| |