Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST | Date | Wed, 13 Jun 2018 12:56:02 +0300 |
| |
kbuild test robot <lkp@intel.com> writes:
> Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on ath6kl/ath-next] > [also build test WARNING on next-20180612] > [cannot apply to v4.17] > [if your patch is applied to the wrong git tree, please drop us a note > to help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Niklas-Cassel/ath10k-do-not-mix-spaces-and-tabs-in-Kconfig/20180612-194241 > base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig > make C=1 CF=-D__CHECK_ENDIAN__ > > > sparse warnings: (new ones prefixed by >>) > >>> drivers/net/wireless/ath/ath10k/snoc.c:823:5: sparse: symbol >>> 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be >>> static? >>> drivers/net/wireless/ath/ath10k/snoc.c:871:6: sparse: symbol >>> 'ath10k_snoc_init_napi' was not declared. Should it be static? > > Please review and possibly fold the followup patch.
There's already a patch pending to fix these:
ath10k: make some functions static
https://patchwork.kernel.org/patch/10440159/
-- Kalle Valo
| |