lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH V2 4/4] mmc: host: Register changes for sdcc V5
    Date
    Quoting Vijay Viswanath (2018-05-29 02:52:41)
    > @@ -137,6 +125,12 @@
    > /* Timeout value to avoid infinite waiting for pwr_irq */
    > #define MSM_PWR_IRQ_TIMEOUT_MS 5000
    >
    > +#define MSM_HOST_READL(msm_host, host, offset) \
    > + msm_host->var_ops->msm_readl_relaxed(host, offset)
    > +
    > +#define MSM_HOST_WRITEL(msm_host, val, host, offset) \
    > + msm_host->var_ops->msm_writel_relaxed(val, host, offset)

    Is there a reason these macros are capitalized? We don't have READL and
    WRITEL macros in the kernel because function-like macros are typically
    lowercase.

    > +
    > struct sdhci_msm_offset {
    > u32 core_hc_mode;
    > u32 core_mci_data_cnt;
    > @@ -268,6 +262,14 @@ struct sdhci_msm_host {
    > const struct sdhci_msm_offset *offset;
    > };
    >
    > +const struct sdhci_msm_offset *sdhci_priv_msm_offset(struct sdhci_host *host)

    static?

    > +{
    > + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
    > + struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host);
    > +
    > + return msm_host->offset;
    > +}
    > +

    \
     
     \ /
      Last update: 2018-06-13 01:26    [W:4.288 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site