lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] test_overflow: fix an IS_ERR() vs NULL bug
On Tue, Jun 12, 2018 at 5:04 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> root_device_register() returns error pointers, it never returns NULL.
>
> Fixes: ca90800a91ba ("test_overflow: Add memory allocation overflow tests")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Ah! Thanks. I'll pull this into my overflow tree for Linus.

-Kees

>
> diff --git a/lib/test_overflow.c b/lib/test_overflow.c
> index aecbbb217305..2278fe05a1b0 100644
> --- a/lib/test_overflow.c
> +++ b/lib/test_overflow.c
> @@ -367,7 +367,7 @@ static int __init test_overflow_allocation(void)
>
> /* Create dummy device for devm_kmalloc()-family tests. */
> dev = root_device_register(device_name);
> - if (!dev) {
> + if (IS_ERR(dev)) {
> pr_warn("Cannot register test device\n");
> return 1;
> }



--
Kees Cook
Pixel Security

\
 
 \ /
  Last update: 2018-06-13 01:20    [W:0.228 / U:1.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site