Messages in this thread | | | Subject | Re: [PATCH] drivers/of: Make of_io_request_and_map() "name" argument optional | From | Benjamin Herrenschmidt <> | Date | Wed, 13 Jun 2018 08:53:59 +1000 |
| |
On Tue, 2018-06-12 at 16:18 -0600, Rob Herring wrote: > On Tue, Jun 12, 2018 at 10:01:07AM +1000, Benjamin Herrenschmidt wrote: > > These days of_address_to_resource() puts a reasonable name > > in the resource struct, thus make the "name" argument an > > optional override. > > > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > --- > > > > Just something I noticed ... we should probably update the > > callers to stop passing stupid names.. > > Sounds like a coccinelle patch.
Quite possibly, though I'm absolutely not proficient with coccinelle :-)
> When do we need an actual name passed in? It does get exposed to > userspace, but no one seemed to care when names changed from full path > (which is commonly used) to just the node name.
Not sure, I had a look at the names looked rather random.
> > Rob > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |