Messages in this thread Patch in this message | | | Subject | Re: [RFC PATCH v4 2/8] usb: typec: helper for checking cable plug orientation | From | Mats Karrman <> | Date | Tue, 12 Jun 2018 20:56:31 +0200 |
| |
Hi Heikki,
On 2018-06-08 13:29, Heikki Krogerus wrote:
> This adds function typec_get_orientation() that can be used > for checking the current cable plug orientation. > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/class.c | 11 +++++++++++ > include/linux/usb/typec.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c > index 53df10df2f9d..02db9bcbac0c 100644 > --- a/drivers/usb/typec/class.c > +++ b/drivers/usb/typec/class.c > @@ -1279,6 +1279,17 @@ int typec_set_orientation(struct typec_port *port, > } > EXPORT_SYMBOL_GPL(typec_set_orientation); > > +/** > + * typec_get_orientation - Get USB Type-C cable plug orientation > + * @port: USB Type-C Port > + * > + * Get current cable plug orientation for @port. > + */ > +enum typec_orientation typec_get_orientation(struct typec_port *port) > +{ > + return port->orientation; > +}
+EXPORT_SYMBOL_GPL(typec_get_orientation);
Isn't this a candidate for an inline?
BR // Mats
> + > /** > * typec_set_mode - Set mode of operation for USB Type-C connector > * @port: USB Type-C port for the connector > diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h > index 672b39bb0adc..a5f6433e218b 100644 > --- a/include/linux/usb/typec.h > +++ b/include/linux/usb/typec.h > @@ -265,6 +265,7 @@ void typec_set_pwr_opmode(struct typec_port *port, enum typec_pwr_opmode mode); > > int typec_set_orientation(struct typec_port *port, > enum typec_orientation orientation); > +enum typec_orientation typec_get_orientation(struct typec_port *port); > int typec_set_mode(struct typec_port *port, int mode); > > #endif /* __LINUX_USB_TYPEC_H */ >
| |