lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/3] scsi: remove Scsi_Cmnd typedef
    Date
    On Tue, 2018-06-12 at 15:53 +0200, Johannes Thumshirn wrote:
    > diff --git a/drivers/scsi/3w-xxxx.c b/drivers/scsi/3w-xxxx.c
    > index f6179e3d6953..5dd05e564760 100644
    > --- a/drivers/scsi/3w-xxxx.c
    > +++ b/drivers/scsi/3w-xxxx.c
    > @@ -1925,7 +1925,7 @@ static int tw_scsi_queue_lck(struct scsi_cmnd *SCpnt, void (*done)(struct scsi_c
    > if (test_bit(TW_IN_RESET, &tw_dev->flags))
    > return SCSI_MLQUEUE_HOST_BUSY;
    >
    > - /* Save done function into Scsi_Cmnd struct */
    > + /* Save done function into struct scsi_cmnd struct */
    ^^^^^^^^^^^^^^^^^^^^^^^
    I think one of the two "struct" occurrences should be removed.

    Otherwise this patch looks fine to me. Hence:

    Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>



    \
     
     \ /
      Last update: 2018-06-12 17:08    [W:3.607 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site