lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 7/7] soc: qcom: rpmpd/rpmhpd: Add a max vote on all corners at init
    Date
    As we move from no clients/consumers in kernel voting on corners,
    to *some* voting and some not voting, we might end up in a situation
    where the clients which remove votes can adversly impact others
    who still don't have a way to vote.

    To avoid this situation, have a max vote on all corners at init.
    This should/can be removed once we have all clients moved to
    be able to vote/unvote for themselves.

    Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
    Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
    ---
    drivers/soc/qcom/rpmhpd.c | 12 +++++++++++-
    drivers/soc/qcom/rpmpd.c | 9 +++++++++
    2 files changed, 20 insertions(+), 1 deletion(-)

    diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
    index 7083ec1590ff..3c753d33aeee 100644
    --- a/drivers/soc/qcom/rpmhpd.c
    +++ b/drivers/soc/qcom/rpmhpd.c
    @@ -329,7 +329,7 @@ static int rpmhpd_update_level_mapping(struct rpmhpd *rpmhpd)

    static int rpmhpd_probe(struct platform_device *pdev)
    {
    - int i, ret;
    + int i, ret, max_level;
    size_t num;
    struct genpd_onecell_data *data;
    struct rpmhpd **rpmhpds;
    @@ -390,6 +390,16 @@ static int rpmhpd_probe(struct platform_device *pdev)
    pm_genpd_init(&rpmhpds[i]->pd, NULL, true);

    data->domains[i] = &rpmhpds[i]->pd;
    +
    + /*
    + * Until we have all consumers voting on corners
    + * just vote the max corner on all PDs
    + * This should ideally be *removed* once we have
    + * all (most) consumers being able to vote
    + */
    + max_level = rpmhpds[i]->level_count - 1;
    + rpmhpd_set_performance(&rpmhpds[i]->pd, rpmhpds[i]->level[max_level]);
    + rpmhpd_power_on(&rpmhpds[i]->pd);
    }

    return of_genpd_add_provider_onecell(pdev->dev.of_node, data);
    diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
    index 53209454c1f3..6440163305e3 100644
    --- a/drivers/soc/qcom/rpmpd.c
    +++ b/drivers/soc/qcom/rpmpd.c
    @@ -310,6 +310,15 @@ static int rpmpd_probe(struct platform_device *pdev)
    pm_genpd_init(&rpmpds[i]->pd, NULL, true);

    data->domains[i] = &rpmpds[i]->pd;
    +
    + /*
    + * Until we have all consumers voting on corners
    + * just vote the max corner on all PDs
    + * This should ideally be *removed* once we have
    + * all (most) consumers being able to vote
    + */
    + rpmpd_set_performance(&rpmpds[i]->pd, MAX_RPMPD_STATE);
    + rpmpd_power_on(&rpmpds[i]->pd);
    }

    return of_genpd_add_provider_onecell(pdev->dev.of_node, data);
    --
    QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
    of Code Aurora Forum, hosted by The Linux Foundation
    \
     
     \ /
      Last update: 2018-06-12 06:42    [W:4.195 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site