Messages in this thread | ![/](/images/icornerl.gif) | | From | Andy Shevchenko <> | Date | Mon, 11 Jun 2018 16:31:08 +0300 | Subject | Re: [PATCH v2 11/24] Bluetooth: hci_bcm: MODULE_DEVICE_TABLE(serdev) |
| |
On Mon, Jun 11, 2018 at 3:59 PM, Marcel Holtmann <marcel@holtmann.org> wrote: > Hi Ricardo, > >> Export serdev table to the module header, allowing module autoload via >> udev/modprobe.
>> static const struct serdev_device_id bcm_serdev_id[] = { >> { "bcm43438-bt", }, >> + { "hci_uart_bcm", }, >> {} >> }; >> +MODULE_DEVICE_TABLE(serdev, bcm_serdev_id); > > so this one I can see real use of and is a good fix to finally clean up hci_bcm.c and remove platform support for the Edison hardware. However, I would really then first rename hci_uart_bcm into some Edison specific string since this is really just one outlier here.
Or other way around, hack arch/x86/platform/intel-mid/device_libs/platform_bt.c to be compatible with these changes (Dunno if it's possible).
-- With Best Regards, Andy Shevchenko
| ![\](/images/icornerr.gif) |