Messages in this thread | | | Subject | Re: [RFC PATCH 4/5] remoteproc: qcom: q6v5-pil: Use common q6v5 helpers | From | Sricharan R <> | Date | Fri, 1 Jun 2018 12:12:53 +0530 |
| |
Hi Bjorn,
On 5/23/2018 10:50 AM, Bjorn Andersson wrote: > Migrate the MSS remoteproc driver to use the newly extracted helper > functions. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/remoteproc/Kconfig | 4 + > drivers/remoteproc/qcom_q6v5_pil.c | 157 +++-------------------------- > 2 files changed, 19 insertions(+), 142 deletions(-) > > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig > index d51d155cf8bd..2316908e9788 100644 > --- a/drivers/remoteproc/Kconfig > +++ b/drivers/remoteproc/Kconfig > @@ -116,6 +116,10 @@ config QCOM_Q6V5_PIL > depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n > depends on QCOM_SYSMON || QCOM_SYSMON=n > select MFD_SYSCON > + select QCOM_Q6V5_COMMON
The below three are duplicate.
> + select QCOM_RPROC_COMMON > + select QCOM_SCM > + select QCOM_Q6V5_COMMON > select QCOM_RPROC_COMMON > select QCOM_SCM
<..>
> @@ -946,16 +934,10 @@ static int q6v5_stop(struct rproc *rproc) > > qproc->running = false; > > - qcom_smem_state_update_bits(qproc->state, > - BIT(qproc->stop_bit), BIT(qproc->stop_bit)); > - > - ret = wait_for_completion_timeout(&qproc->stop_done, > - msecs_to_jiffies(5000)); > - if (ret == 0) > + ret = qcom_q6v5_request_stop(&qproc->q6v5); > + if (ret == -ETIMEDOUT) > dev_err(qproc->dev, "timed out on wait\n"); > > - qcom_smem_state_update_bits(qproc->state, BIT(qproc->stop_bit), 0); > - > q6v5proc_halt_axi_port(qproc, qproc->halt_map, qproc->halt_q6); > q6v5proc_halt_axi_port(qproc, qproc->halt_map, qproc->halt_modem); > q6v5proc_halt_axi_port(qproc, qproc->halt_map, qproc->halt_nc); > @@ -976,9 +958,8 @@ static int q6v5_stop(struct rproc *rproc) > > q6v5_reset_assert(qproc); > > - disable_irq(qproc->handover_irq); > - > - if (!qproc->proxy_unvoted) { > + ret = qcom_q6v5_unprepare(&qproc->q6v5); > + if (ret) { > q6v5_clk_disable(qproc->dev, qproc->proxy_clks, > qproc->proxy_clk_count); > q6v5_regulator_disable(qproc, qproc->proxy_regs,
Nit, can qcom_msa_handover api be used instead here ?
Rest all looks good, reviewed-by: Sricharan R <sricharan@codeaurora.org>
Regards, Sricharan
-- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
--- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus
| |