lkml.org 
[lkml]   [2018]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH 5/8] coresight: Handle errors in finding input/output ports
    Date
    If we fail to find the input / output port for a LINK component
    while enabling a path, we should fail gracefully rather than
    assuming port "0".

    Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
    ---
    drivers/hwtracing/coresight/coresight.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
    index 3b3756e..4dcea6e 100644
    --- a/drivers/hwtracing/coresight/coresight.c
    +++ b/drivers/hwtracing/coresight/coresight.c
    @@ -115,7 +115,7 @@ static int coresight_find_link_inport(struct coresight_device *csdev,
    dev_err(&csdev->dev, "couldn't find inport, parent: %s, child: %s\n",
    dev_name(&parent->dev), dev_name(&csdev->dev));

    - return 0;
    + return -ENODEV;
    }

    static int coresight_find_link_outport(struct coresight_device *csdev,
    @@ -133,7 +133,7 @@ static int coresight_find_link_outport(struct coresight_device *csdev,
    dev_err(&csdev->dev, "couldn't find outport, parent: %s, child: %s\n",
    dev_name(&csdev->dev), dev_name(&child->dev));

    - return 0;
    + return -ENODEV;
    }

    static int coresight_enable_sink(struct coresight_device *csdev, u32 mode)
    @@ -186,6 +186,9 @@ static int coresight_enable_link(struct coresight_device *csdev,
    else
    refport = 0;

    + if (refport < 0)
    + return refport;
    +
    if (atomic_inc_return(&csdev->refcnt[refport]) == 1) {
    if (link_ops(csdev)->enable) {
    ret = link_ops(csdev)->enable(csdev, inport, outport);
    --
    2.7.4
    \
     
     \ /
      Last update: 2018-06-01 15:19    [W:4.335 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site