Messages in this thread | | | Subject | Re: [PATCH 4/4] rtc: ds1307: add frequency-test property to check calibration on m41txx | From | Giulio Benetti <> | Date | Wed, 9 May 2018 20:32:38 +0200 |
| |
Hi Rob,
Il 08/05/2018 19:44, Rob Herring ha scritto: > On Tue, May 8, 2018 at 9:56 AM, Giulio Benetti > <giulio.benetti@micronovasrl.com> wrote: >> On m41txx you can enable open-drain OUT pin to check if calibration is ok. >> Enabling OUT pin with frequency-test bool property, OUT pin will tick >> 512 times faster than 1s tick base. >> >> Enable FT bit on CONTROL register if calibration is active. > > A DT is (or should be) a pretty static thing, so I don't think this > belongs. A kernel command line option (via module params) or a > sysfs/debugfs file would make more sense IMO.
Totally right, it's very useful having it accessible via sysfs. Already changed and just submitted V2 patchset. Thanks
-- Giulio Benetti CTO
MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale € 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
| |