Messages in this thread |  | | Date | Wed, 9 May 2018 08:08:06 -0400 | From | Vivek Unune <> | Subject | Re: [PATCH v2] ARM: dts: BCM5301X: Make usb3 phy use mdio phy driver |
| |
On Wed, Apr 18, 2018 at 03:31:17PM -0700, Florian Fainelli wrote: > On 04/09/2018 03:31 PM, Vivek Unune wrote: > > Currently, usb3 phy in bcm5301x.dtsi uses platform driver which > > requires register range "ccb-mii" <0x18003000 0x1000>. This range > > overlaps with mdio cmd and param registers (<0x18003000 0x8>). > > Essentially, the platform driver partly acts like a mdio bus > > driver, hence to use of this register range. > > > > In some Northstar devices like Linksys EA9500, secondary switch > > is connected via external mdio. The only way to access and > > configure the external switch is via mdio bus. When we enable the > > mdio bus in it's current state, the mdio bus and any child buses > > fail to register because of the register range overlap. > > > > On Northstar, the usb3 phy is connected at address 0x10 on the > > internal mdio bus. This change moves the usb3_phy node and makes > > it a child node of internal mdio bus. > > > > Thanks to Rafał Miłecki's commit af850e14a7ae > > ("phy: bcm-ns-usb3: add MDIO driver using proper bus layer") the > > same usb3 platform driver can now act as usb3 phy mdio driver. > > > > Tested on Linksys Panamera (EA9500) > > > > Signed-off-by: Vivek Unune <npcomplete13@gmail.com> > > --- > > v2: Disabled usb3_phy by default, then enabled in dts where > > necessary > > Rafal, Hauke, this looks good to me, can you review? Thanks > -- > Florian
Rafał, Hauke,
I'm sure you are super busy :) Just want to bring this to your attention.
Thanks,
Vivek
|  |