Messages in this thread | | | Date | Wed, 09 May 2018 17:09:54 +0530 | From | Amit Nischal <> | Subject | Re: [PATCH v1 0/2] Add QCOM video clock controller driver |
| |
On 2018-05-09 01:45, Stephen Boyd wrote: > Quoting Rob Herring (2018-05-08 05:48:07) >> On Mon, May 7, 2018 at 11:53 PM, Amit Nischal >> <anischal@codeaurora.org> wrote: >> > On 2018-05-07 22:41, Rob Herring wrote: >> >> >> >> On Mon, May 07, 2018 at 04:16:53PM +0530, Amit Nischal wrote: >> >>> >> >>> On 2018-05-04 22:01, Stephen Boyd wrote: >> >>> > Quoting Amit Nischal (2018-05-03 05:35:23) >> >>> > > Changes in v1: >> >>> > > https://lkml.org/lkml/2018/4/24/545 >> >>> > > Addressed below review comments given by Rob >> >>> > > - Change the compatible property as per '<vendor>,<soc>-<block>' >> >>> > > format. >> >>> > > - Add header definitions for resets and power-domain cells. >> >>> > >> >>> > You didn't add any reset definitions though? >> >>> >> >>> We haven't added the reset definitions for videocc as there is no >> >>> video reset client. >> >> >> >> >> >> So? You don't know what resets there are? >> >> >> > >> > We know the resets, but video driver doesn't do any block resets >> > prior to accessing the video subsystem so that's the reason we do >> > not want to expose the resets in videocc driver. >> >> Bindings don't have to match what drivers currently use but should be >> complete as possible. > > Right. Please add the #defines in the header file for the resets. You > can leave them out of the driver if you really want to, but typically > we > still add them and then rely on not touching them if they shouldn't be > used.
Thanks for the suggestion. I will add the videocc resets in the header file.
| |