lkml.org 
[lkml]   [2018]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.
Hi Bjorn,

On Tue, May 08, 2018 at 07:56:58AM -0500, Bjorn Helgaas wrote:
...
> > + return ret;
> > + }
> > + }
> > +
> > + pci->pp.root_bus_nr = -1;
>
> Setting root_bus_nr looks like an unrelated change that should be in a
> separate patch.
>
> But I'm not sure why you need to set root_bus_nr at all, since
> dw_pcie_host_init() always sets it.
>
> Some other callers of dw_pcie_host_init() do set it:
>
> exynos_add_pcie_port()
> imx6_add_pcie_port()
> armada8k_add_pcie_port()
> artpec6_add_pcie_port()
> dw_plat_add_pcie_port()
> histb_pcie_probe()
> qcom_pcie_probe()
> spear13xx_add_pcie_port()
>
> But I don't see *why* any of these need to set it. If they don't need to
> set it, they shouldn't.

Mostly it's a blind copy of unnecessary code. I tested histb driver
by dropping the line, and did not see anything broken. I will cook up
a series to remove the code from all above drivers, and copy
corresponding driver owner to comment.

> And it would be nice if histb and qcom followed the structure and naming
> conventions of the other drivers, i.e., they should have
> histb_add_pcie_port() and qcom_add_pcie_port().

I can create a patch for histb driver, but will leave qcom one to
Stanimir to decide.

Shawn

>
> > pci->pp.ops = &kirin_pcie_host_ops;
> >
> > return dw_pcie_host_init(&pci->pp);
> > --
> > 1.9.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

\
 
 \ /
  Last update: 2018-05-09 06:52    [W:0.081 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site