Messages in this thread | | | Subject | Re: [PATCH 2/2] tools/testing/selftests/x86: fix error: conflicting types for 'pkey_get|pkey_set' | From | Shuah Khan <> | Date | Tue, 8 May 2018 11:36:17 -0600 |
| |
On 05/08/2018 10:30 AM, Dave Hansen wrote: > On 05/08/2018 02:14 AM, Li Zhijian wrote: >> -u32 pkey_get(int pkey, unsigned long flags) >> +u32 _pkey_get(int pkey, unsigned long flags) >> { >> u32 mask = (PKEY_DISABLE_ACCESS|PKEY_DISABLE_WRITE); >> u32 pkru = __rdpkru(); >> @@ -422,7 +426,7 @@ u32 pkey_get(int pkey, unsigned long flags) >> return masked_pkru; >> } > > I'm not a huge fan of random underscores for undocumented reasons. But, > oh well. > > Acked-by: Dave Hansen <dave.hansen@intel.com> >
Thanks. Queuing this up for 4.17-rc5
-- Shuah
| |