Messages in this thread | | | From | Masahiro Yamada <> | Date | Mon, 7 May 2018 15:42:57 +0900 | Subject | Re: [RFCv2 PATCH 3/3] x86/vdso: Add build salt to the vDSO |
| |
2018-03-30 3:01 GMT+09:00 Laura Abbott <labbott@redhat.com>: > The vDSO is linked separately from the kernel and modules. Ensure it picks > up the comment section, if available. > > Signed-off-by: Laura Abbott <labbott@redhat.com> > --- > v2: Updated name > --- > arch/x86/entry/vdso/vdso-layout.lds.S | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/entry/vdso/vdso-layout.lds.S b/arch/x86/entry/vdso/vdso-layout.lds.S > index acfd5ba7d943..7c78dd39aae8 100644 > --- a/arch/x86/entry/vdso/vdso-layout.lds.S > +++ b/arch/x86/entry/vdso/vdso-layout.lds.S > @@ -1,5 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > #include <asm/vdso.h> > +#include <generated/build-salt.h> > > /* > * Linker script for vDSO. This is an ELF shared object prelinked to > @@ -95,6 +96,8 @@ SECTIONS > .altinstructions : { *(.altinstructions) } :text > .altinstr_replacement : { *(.altinstr_replacement) } :text > > + BUILD_ID_SALT > + > /DISCARD/ : { > *(.discard) > *(.discard.*) > -- > 2.16.2 >
For consistency, I think '-T scripts/build-salt.lds' should be passed to cmd_vdso in arch/x86/entry/vdso/Makefile.
-- Best Regards Masahiro Yamada
| |