Messages in this thread | | | From | Masahiro Yamada <> | Date | Mon, 7 May 2018 15:38:03 +0900 | Subject | Re: [RFCv2 PATCH 2/3] kbuild: Link with generated build-salt header |
| |
2018-03-30 3:01 GMT+09:00 Laura Abbott <labbott@redhat.com>:
> diff --git a/scripts/build-salt.lds.S b/scripts/build-salt.lds.S > new file mode 100644 > index 000000000000..f85981f1187e > --- /dev/null > +++ b/scripts/build-salt.lds.S > @@ -0,0 +1,5 @@ > +#include <generated/build-salt.h> > + > +SECTIONS { > + BUILD_ID_SALT > +}
Do you need this just for wrapping <generate/build-salt.h> ?
How about generating scripts/build-salt.lds directly by scripts/gensalt ?
<generated/build-salt.h> is unneeded, then "some sporadic failures about missing the generated header" will be solved.
I think something like follows will be simpler and better.
always := $(hostprogs-y) $(hostprogs-m) build-salt.lds
define filechk_build-salt.lds ($(CONFIG_SHELL) $(srctree)/scripts/gensalt $(CONFIG_BUILD_ID_SALT)) endef
$(obj)/build-salt.lds: $(src)/gensalt FORCE $(call filechk,build-salt.lds)
-- Best Regards Masahiro Yamada
| |