Messages in this thread | | | From | NeilBrown <> | Date | Sun, 06 May 2018 07:49:40 +1000 | Subject | Re: [PATCH 1/8] rhashtable: silence RCU warning in rhashtable_test. |
| |
On Sat, May 05 2018, Herbert Xu wrote:
> On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> print_ht in rhashtable_test calls rht_dereference() with neither >> RCU protection or the mutex. This triggers an RCU warning. >> So take the mutex to silence the warning. >> >> Signed-off-by: NeilBrown <neilb@suse.com> > > I don't think the mutex is actually needed but since we don't > have rht_dereference_raw and this is just test code:
I agrees there is no functional need for the mutex. It just needed to silence the warning, so that other warnings are easier to see.
> > Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
thanks, NeilBrown
> -- > Email: Herbert Xu <herbert@gondor.apana.org.au> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt [unhandled content-type:application/pgp-signature] | |