| From | Amir Goldstein <> | Date | Sat, 5 May 2018 19:37:20 +0300 | Subject | Re: [RFC PATCH 00/35] overlayfs: stack file operations |
| |
On Fri, May 4, 2018 at 6:23 PM, Miklos Szeredi <miklos@szeredi.hu> wrote: > On Thu, Apr 12, 2018 at 5:07 PM, Miklos Szeredi <mszeredi@redhat.com> wrote: > >> Git tree is here: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-rorw > > Thanks everyone for your review. > > Force pushed new version to the above branch. > > Hopefully no comment was missed (I didn't add more reverts yet, those > can wait). I'll do a mailbomb as well next week and start processing > the metacopy patches. >
Ran -g auto xfstests on overlay over xfs+reflink. There are no failures and no changes w.r.t skipped tests since v4.17-rc1.
ACK on w.r.t addressing my review comments.
ACK on the freeze protection fix. Not sure if the fact that we take __mnt_want_write() on overlay and not on upper_mnt for ovl_real_ioctl() is a problem (i.e. can upper_mnt become readonly from under overlay? and do we care?).
Thanks, Amir.
|