Messages in this thread | | | Date | Thu, 31 May 2018 11:45:28 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v2 3/9] PM / Domains: Drop genpd as in-param for pm_genpd_remove_device() |
| |
On 29-05-18, 12:04, Ulf Hansson wrote: > There is no need to pass a genpd struct to pm_genpd_remove_device(), as we > already have the information about the PM domain (genpd) through the device > structure. > > Additionally, we don't allow to remove a PM domain from a device, other > than the one it may have assigned to it, so really it does not make sense > to have a separate in-param for it. > > For these reason, drop it and update the current only call to > pm_genpd_remove_device() from amdgpu_acp. > > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Christian König <christian.koenig@amd.com> > Cc: David (ChunMing) Zhou <David1.Zhou@amd.com> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/base/power/domain.c | 8 ++++---- > drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +- > include/linux/pm_domain.h | 5 ++--- > 3 files changed, 7 insertions(+), 8 deletions(-)
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
-- viresh
| |