| From | Andy Shevchenko <> | Date | Thu, 31 May 2018 21:41:36 +0300 | Subject | Re: [PATCH v2 15/21] ALSA: oxygen: use match_string() helper |
| |
On Thu, May 31, 2018 at 2:11 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote: > match_string() returns the index of an array for a matching string, > which can be used instead of open coded variant.
Sorry, didn't notice before one thing:
> + j = match_string(known_ctl_names, CONTROL_COUNT, ctl->id.name); > + if (j >= 0) { > + chip->controls[j] = ctl; > + ctl->private_free = oxygen_any_ctl_free; > + }
It looks to me you may get rid of j completely by utilizing existing err.
-- With Best Regards, Andy Shevchenko
|