lkml.org 
[lkml]   [2018]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v5 04/10] sched/dl: add dl_rq utilization tracking
    On 30 May 2018 at 12:50, Patrick Bellasi <patrick.bellasi@arm.com> wrote:
    > On 25-May 15:12, Vincent Guittot wrote:
    >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
    >> index fb18bcc..967e873 100644
    >> --- a/kernel/sched/fair.c
    >> +++ b/kernel/sched/fair.c
    >> @@ -7290,11 +7290,14 @@ static inline bool cfs_rq_has_blocked(struct cfs_rq *cfs_rq)
    >> return false;
    >> }
    >>
    >> -static inline bool rt_rq_has_blocked(struct rq *rq)
    >> +static inline bool others_rqs_have_blocked(struct rq *rq)
    >
    > Here you are going to fold in IRQ's utilization which, strictly
    > speaking, is not a RQ. Moreover, we are checking only utilization.
    >
    > Can we use a better matching name? E.g.
    > others_have_blocked_util
    > non_cfs_blocked_util

    others_have_blocked looks ok and consistent with cfs_rq_has_blocked

    > ?
    >
    >> {
    >> if (rq->avg_rt.util_avg)
    >> return true;
    >>
    >> + if (rq->avg_dl.util_avg)
    >> + return true;
    >> +
    >> return false;
    >> }
    >>
    > --
    > #include <best/regards.h>
    >
    > Patrick Bellasi

    \
     
     \ /
      Last update: 2018-05-30 13:52    [W:2.317 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site