Messages in this thread | | | Date | Wed, 30 May 2018 14:01:45 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH] tpm: fix race condition in tpm_common_write() |
| |
On Wed, May 23, 2018 at 01:41:15PM -0600, Jason Gunthorpe wrote: > On Wed, May 23, 2018 at 10:57:07AM -0700, Tadeusz Struk wrote: > > On 05/23/2018 06:23 AM, Jarkko Sakkinen wrote: > > > Ouch o_O Do you have a fixes tag for this one? > > > > > > > This one is quite tricky. > > The original bug was introduced by abce9ac292e13 (tpm: Propagate error from tpm_transmit to fix a timeout hang) > > and the code back then was in drivers/char/tpm/tpm-interface.c file > > No, it has been wrong since before git history started, so just use > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > All the other commits you listed are just moving the bad code around > to new files. > > Jason
OK, thank you Jason. I'll use that.
/Jarkko
| |