Messages in this thread | | | Date | Wed, 30 May 2018 11:37:20 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v4 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings |
| |
On Tue, May 29, 2018 at 10:23:20PM -0700, Doug Anderson wrote:
> > + qcom,drms-mode-max-microamps = <10000 1000000>;
> Things look pretty good to me now. I'm still hesitant about the whole > need to list the modes twice (once using the unordered > "regulator-allowed-modes" and once to match up against the ordered > "qcom,drms-mode-max-microamps"). I'm also still of the opinion that > the whole "drms-mode-max-microamps" ought to be a standard property > (not a qcom specific one) and handled in the regulator core.
I'm confused as to why we are specifying the maximum current the device can deliver in a given mode in the DT - surely that's a fixed property of the hardware? [unhandled content-type:application/pgp-signature] | |