Messages in this thread | | | Subject | Re: [PATCH] cpupower : Fix header name to read idle state name | From | Shuah Khan <> | Date | Wed, 30 May 2018 21:39:36 -0600 |
| |
On 05/28/2018 05:03 AM, Abhishek Goel wrote: > The names of the idle states in the output of cpupower monitor command are > truncated to 4 characters. On POWER9, this creates ambiguity as the states > are named "stop0", "stop1", etc. > > root:~# cpupower monitor > |Idle_Stats > PKG |CORE|CPU | snoo | stop | stop | stop | stop | stop | stop > 0| 0| 0| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00| 1.90 > 0| 0| 1| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00 > 0| 0| 2| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00 > 0| 0| 3| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00 > > This patch modifies the output to print the state name that results in a > legible output. The names will be printed with atmost 1 padding in left. > > root:~# cpupower monitor > | Idle_Stats > PKG|CORE| CPU|snooze|stop0L| stop0|stop1L| stop1|stop2L| stop2 > 0| 0| 0| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00| 0.72 > 0| 0| 1| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00 > 0| 0| 2| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00 > 0| 0| 3| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00| 0.00 > > This patch does not affect the output for intel. > Output for intel before applying the patch: > > root:~# cpupower monitor > |Idle_Stats > CPU | POLL | C1-S | C1E- | C3-S | C6-S | C7s- | C8-S | C9-S | C10- > 0| 0.00| 0.14| 0.39| 0.35| 7.41| 0.00| 17.67| 1.01| 70.03 > 2| 0.00| 0.19| 0.47| 0.10| 6.50| 0.00| 29.66| 2.17| 58.07 > 1| 0.00| 0.11| 0.50| 1.50| 9.11| 0.18| 18.19| 0.40| 66.63 > 3| 0.00| 0.67| 0.42| 0.03| 5.84| 0.00| 12.58| 0.77| 77.14 > > Output for intel after applying the patch: > > root:~# cpupower monitor > | Idle_Stats > CPU| POLL | C1-S | C1E- | C3-S | C6-S | C7s- | C8-S | C9-S | C10- > 0| 0.03| 0.33| 1.01| 0.27| 3.03| 0.00| 19.18| 0.00| 71.24 > 2| 0.00| 1.58| 0.58| 0.42| 8.55| 0.09| 21.11| 0.99| 63.32 > 1| 0.00| 1.26| 0.88| 0.43| 9.00| 0.02| 7.78| 4.65| 71.91 > 3| 0.00| 0.30| 0.42| 0.06| 13.62| 0.21| 30.29| 0.00| 52.45 > > Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com> > --- >
Thanks - I have this queued for 4.18-rc1
-- Shuah
| |