Messages in this thread Patch in this message | | | From | Randy Dunlap <> | Subject | [PATCH -next] zram: fix printk formats in zram_drv.c | Date | Thu, 3 May 2018 11:21:06 -0700 |
| |
From: Randy Dunlap <rdunlap@infradead.org>
Fix printk format warnings (seen on i386 build):
../drivers/block/zram/zram_drv.c:678:4: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘ssize_t’ [-Wformat=] ../drivers/block/zram/zram_drv.c:678:4: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘time64_t’ [-Wformat=]
time64_t is 64 bits (and signed), so printing it should use %lld, not %ld. %ld (long) is only 32 bits on several architectures.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Nitin Gupta <ngupta@vflare.org> Cc: Minchan Kim <minchan@kernel.org> Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> --- drivers/block/zram/zram_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20180503.orig/drivers/block/zram/zram_drv.c +++ linux-next-20180503/drivers/block/zram/zram_drv.c @@ -671,7 +671,7 @@ static ssize_t read_block_state(struct f ts = ktime_to_timespec64(zram->table[index].ac_time); copied = snprintf(kbuf + written, count, - "%12lu %12lu.%06lu %c%c%c\n", + "%12zd %12lld.%06lu %c%c%c\n", index, ts.tv_sec, ts.tv_nsec / NSEC_PER_USEC, zram_test_flag(zram, index, ZRAM_SAME) ? 's' : '.', zram_test_flag(zram, index, ZRAM_WB) ? 'w' : '.',
| |