Messages in this thread | | | Subject | Re: [PATCH 1/2] iommu/amd - Update the PASID information printed to the system log | From | Gary R Hook <> | Date | Thu, 3 May 2018 13:09:18 -0500 |
| |
On 05/03/2018 08:57 AM, Joerg Roedel wrote: > On Tue, May 01, 2018 at 02:52:52PM -0500, Gary R Hook wrote: >> @@ -567,7 +567,7 @@ static void iommu_print_event(struct amd_iommu *iommu, void *__evt) >> } >> >> if (type == EVENT_TYPE_IO_FAULT) { >> - amd_iommu_report_page_fault(devid, domid, address, flags); >> + amd_iommu_report_page_fault(devid, pasid, address, flags); > > According to the spec this could be a domid or a pasid, it would be good > to make that visible in the error message, depending on the value of the > GN flag in the event entry. > > But that can be done in a separate patch, I applied these two, thanks.
Yes, I didn't quite get this right. Both values should be passed along. Or perhaps the entire event could be passed in and decoded by amd_iommu_report_page_fault()?
| |