lkml.org 
[lkml]   [2018]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] clk: qcom: clk-rpmh: Add QCOM RPMh clock driver
Date
Quoting Taniya Das (2018-05-03 03:33:10)
> Hello Stephen,
>
> Thanks for review.
>
> On 5/2/2018 9:00 PM, Stephen Boyd wrote:
> > Quoting Taniya Das (2018-05-02 03:51:17)
> >> + ret = devm_clk_hw_register(&pdev->dev, hw_clks[i]);
> >> + if (ret) {
> >> + dev_err(&pdev->dev, "failed to register %s\n",
> >> + hw_clks[i]->init->name);
> >> + goto err;
> >> + }
> >> +
> >> + rpmh_clk->dev = &pdev->dev;
> >> + }
> >> +
> >> + ret = devm_of_clk_add_hw_provider(&pdev->dev, of_clk_rpmh_hw_get,
> >> + (void *) desc);
> >
> > Drop the void cast.
> >
>
> I see a compiler warning, that is the reason to keep the void cast.
> /include/linux/clk-provider.h:881:5: note: expected ‘void *’ but
> argument is of type ‘const struct clk_rpmh_desc *’

Ok. Casting away const is not good though. Can you pass a pointer to the
hw_clks array instead?

\
 
 \ /
  Last update: 2018-05-03 19:05    [W:0.165 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site