lkml.org 
[lkml]   [2018]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] ixgbe: release lock for the duration of ixgbe_suspend_close()
    Hi Alex,

    > I'm not a fan of dropping the mutex while we go through
    > ixgbe_close_suspend. I'm concerned it will result in us having a
    > number of races on shutdown.

    I would agree, but ixgbe_close_suspend() is already called without this
    mutex from ixgbe_close(). This path is executed also during machine
    shutdown but when kexec'ed. So, it is either an existing bug or there are
    no races. But, because ixgbe_close() is called from the userland, and a
    little earlier than ixgbe_shutdown() I think this means there are no races.


    > If anything, I think we would need to find a replacement for the mutex
    > that can operate at the per-netdev level if you are wanting to
    > parallelize this.

    Yes, if lock is necessary, it can be replaced in this place (and added to
    ixgbe_close()) with something scalable.

    Thank you,
    Pavel

    \
     
     \ /
      Last update: 2018-05-03 15:31    [W:2.229 / U:0.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site