Messages in this thread | | | Subject | Re: [PATCH v2 00/10] PCI: leak fixes, removable generic PCI host, assorted stuff | From | Vladimir Zapolskiy <> | Date | Thu, 3 May 2018 10:12:54 +0300 |
| |
Hi Jan,
On 04/30/2018 08:48 AM, Jan Kiszka wrote: > Changes in v2: > - patch 1: commit message reworking as suggested by Lorenzo > - patch 3-6: split-up as suggested by Bjorn > - patch 8: new > - patch 10: select PCI_DOMAINS from PCI_HOST_GENERIC, rather than > allowing manual choice, as suggested by Lorenzo > > This primarily enables to unbind the generic PCI host controller without > leaving lots of memory leaks behind. A previous proposal patch 5 was > rejected because of those issues [1]. > > The fixes have been validated in the Jailhouse setup, where we add and > remove a virtual PCI host controller on hypervisor activation/ > deactivation, with the help of kmemleak.
by chance I was looking into a memleak in of_pci_get_host_bridge_resources(), so I can give you a number of review tags.
FWIW the state of unfixably broken https://patchwork.kernel.org/patch/9662893/ should be changed to obsoleted/deprecated/rejected.
-- With best wishes, Vladimir
| |