Messages in this thread | | | Subject | Re: [PATCH 2/2] clk: qcom: clk-rpmh: Add QCOM RPMh clock driver | From | Taniya Das <> | Date | Thu, 3 May 2018 16:03:10 +0530 |
| |
Hello Stephen,
Thanks for review.
On 5/2/2018 9:00 PM, Stephen Boyd wrote: > Quoting Taniya Das (2018-05-02 03:51:17) >> + ret = devm_clk_hw_register(&pdev->dev, hw_clks[i]); >> + if (ret) { >> + dev_err(&pdev->dev, "failed to register %s\n", >> + hw_clks[i]->init->name); >> + goto err; >> + } >> + >> + rpmh_clk->dev = &pdev->dev; >> + } >> + >> + ret = devm_of_clk_add_hw_provider(&pdev->dev, of_clk_rpmh_hw_get, >> + (void *) desc); > > Drop the void cast. >
I see a compiler warning, that is the reason to keep the void cast. /include/linux/clk-provider.h:881:5: note: expected ‘void *’ but argument is of type ‘const struct clk_rpmh_desc *’
>> + if (ret) { >> + dev_err(&pdev->dev, "Failed to add clock provider\n"); >> + goto err; >> + } >> + >> + dev_dbg(&pdev->dev, "Registered RPMh clocks\n"); >> + >> + return 0; >> +err: >> + if (rpmh_client) >> + rpmh_release(rpmh_client); >> + >> + return ret; >> +} >> + >> +static int clk_rpmh_remove(struct platform_device *pdev) >> +{ >> + const struct clk_rpmh_desc *desc = >> + of_device_get_match_data(&pdev->dev); >> + struct clk_hw **hw_clks = desc->clks; >> + struct clk_rpmh *rpmh_clk = to_clk_rpmh(hw_clks[0]); >> + >> + rpmh_release(rpmh_clk->rpmh_client); >> + >> + return 0; >> +} > > I'll review Lina's series again. Still hoping to drop the client thing. >
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation.
--
| |